Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix TM UI bug with DS available logic#4900

Merged
mattjackson220 merged 1 commit intoapache:masterfrom
rob05c:tm-fix-ui-ds-available-bug
Jul 21, 2020
Merged

Fix TM UI bug with DS available logic#4900
mattjackson220 merged 1 commit intoapache:masterfrom
rob05c:tm-fix-ui-ds-available-bug

Conversation

@rob05c
Copy link
Member

@rob05c rob05c commented Jul 21, 2020

No tests, TM doesn't have a test framework for the UI
No docs, no interface change
No changelog, no interface change

Which Traffic Control components are affected by this PR?

  • Traffic Monitor

What is the best way to verify this PR?

Run monitor, verify DS pane has DSes as available

If this is a bug fix, what versions of Traffic Control are affected?

  • master

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@rob05c rob05c added bug something isn't working as intended Traffic Monitor related to Traffic Monitor labels Jul 21, 2020
@rob05c rob05c requested a review from mattjackson220 July 21, 2020 16:38
mattjackson220
mattjackson220 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@mattjackson220 mattjackson220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! code runs as expected. shows available when available and shows unavailable with error message when unavailable

@mattjackson220 mattjackson220 merged commit fb06602 into apache:master Jul 21, 2020
rawlinp pushed a commit to rawlinp/trafficcontrol that referenced this pull request Nov 6, 2020
@rawlinp
Fix TM UI bug with DS available logic (apache#4900)
25f188f 
(cherry picked from commit fb06602)
@rawlinp rawlinp mentioned this pull request Nov 6, 2020
Merged
rawlinp added a commit that referenced this pull request Nov 6, 2020
@rawlinp @rob05c
[4.1.x backport] Fix TM UI bug with DS available logic #4900 (#5255)
09377cc 
* Fix TM UI bug with DS available logic (#4900)

(cherry picked from commit fb06602)

* Add changelog entry

Co-authored-by: Robert O Butts <rob05c@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mattjackson220 mattjackson220 mattjackson220 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug something isn't working as intended Traffic Monitor related to Traffic Monitor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Traffic Monitor Web UI showing incorrect status in Delivery Service States

2 participants

@rob05c @mattjackson220