This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Update angular to 1.8.0#4904
Merged
mitchell852 merged 1 commit intoapache:masterfrom Jul 23, 2020
shamrickus:tp/update-angular
Merged
Update angular to 1.8.0#4904mitchell852 merged 1 commit intoapache:masterfrom shamrickus:tp/update-angular
mitchell852 merged 1 commit intoapache:masterfrom
shamrickus:tp/update-angular
Conversation
mitchell852
approved these changes
Jul 23, 2020
Member
mitchell852
left a comment
There was a problem hiding this comment.
lgtm. builds fine and runs fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
There was a breaking change in angular 1.8.0 to jqLite, however we do not use jqLite. It comes built-in with angular; however, it gets superseded by a loaded jQuery.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run integration tests.
Ensure TP loads and appears to look/work correctly.
The following criteria are ALL met by this PR
Additional Information
Notes: