Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Update angular to 1.8.0#4904

Merged
mitchell852 merged 1 commit intoapache:masterfrom
shamrickus:tp/update-angular
Jul 23, 2020
Merged

Update angular to 1.8.0#4904
mitchell852 merged 1 commit intoapache:masterfrom
shamrickus:tp/update-angular

Conversation

@shamrickus
Copy link
Member

What does this PR (Pull Request) do?

  • This PR is not related to any Issue. It updates angular to the latest version.

There was a breaking change in angular 1.8.0 to jqLite, however we do not use jqLite. It comes built-in with angular; however, it gets superseded by a loaded jQuery.

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Run integration tests.
Ensure TP loads and appears to look/work correctly.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Notes:

## Breaking Changes

### **jqLite** due to:
  - **[2df43c](https://github.com/angular/angular.js/commit/2df43c07779137d1bddf7f3b282a1287a8634acd)**: prevent possible XSS due to regex-based HTML replacement

## Bug Fixes
- **jqLite:**
  - prevent possible XSS due to regex-based HTML replacement
  ([2df43c](https://github.com/angular/angular.js/commit/2df43c07779137d1bddf7f3b282a1287a8634acd))
- **angular.merge:** do not merge __proto__ property
  ([726f49](https://github.com/angular/angular.js/commit/726f49dcf6c23106ddaf5cfd5e2e592841db743a))
- **ngStyle:** correctly remove old style when new style value is invalid
  ([5edd25](https://github.com/angular/angular.js/commit/5edd25364f617083363dc2bd61f9230b38267578),
  [#16860](https://github.com/angular/angular.js/issues/16860),
  [#16868](https://github.com/angular/angular.js/issues/16868))

@ocket8888 ocket8888 added tech debt rework due to choosing easy/limited solution Traffic Portal v1 related to Traffic Portal version 1 labels Jul 22, 2020
@ocket8888 ocket8888 requested a review from mitchell852 July 22, 2020 21:56
@mitchell852 mitchell852 self-assigned this Jul 23, 2020
Copy link
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. builds fine and runs fine.

@mitchell852 mitchell852 merged commit e53ba65 into apache:master Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tech debt rework due to choosing easy/limited solution Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants