Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Traffic Portal tests in CiaB: Pin ChromeDriver to version of Chrome that we installed#4911

Merged
mitchell852 merged 1 commit intoapache:masterfrom
zrhoffman:pin-chromedriver-version
Jul 24, 2020
Merged

Traffic Portal tests in CiaB: Pin ChromeDriver to version of Chrome that we installed#4911
mitchell852 merged 1 commit intoapache:masterfrom
zrhoffman:pin-chromedriver-version

Conversation

@zrhoffman
Copy link
Member

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

When the ChromeDriver version that webdriver-mananger installs is newer than the version of Chrome that is installed, the traffic_portal_integration_test CDN-in-a-Box container fails with

portal-integration-test_1  | [06:09:06] E/launcher - SessionNotCreatedError: session not created: This version of ChromeDriver only supports Chrome version 85

Which Traffic Control components are affected by this PR?

  • CDN in a Box

What is the best way to verify this PR?

Run TP tests in CDN-in-a-Box and verify they succeed.

docker-compose up -d trafficportal trafficops trafficvault && \
docker-compose -f docker-compose.yml -f docker-compose.traffic-portal-test.yml up --build portal-integration-test

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR fixes tests
  • Bugfix, no documentation necessary
  • An update to CHANGELOG.md is not necessary
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@ocket8888 ocket8888 added bug something isn't working as intended cdn-in-a-box related to the Docker-based CDN-in-a-Box system tests related to tests and/or testing infrastructure labels Jul 24, 2020
@mitchell852 mitchell852 merged commit a3d7d7f into apache:master Jul 24, 2020
@zrhoffman zrhoffman deleted the pin-chromedriver-version branch July 24, 2020 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended cdn-in-a-box related to the Docker-based CDN-in-a-Box system tests related to tests and/or testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants