This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Merged
Conversation
…ffic portal server summary page
…o refactor/traffic_portal_ui � Conflicts: � traffic_portal/app/src/common/modules/table/servers/TableServersController.js
rimashah25
commented
Jul 27, 2020
| @@ -10,7 +10,7 @@ | |||
| "defaultTimeoutInterval": 600000 | |||
| }, | |||
| "params": { | |||
Contributor
Author
There was a problem hiding this comment.
CIAB would normally change the password for TP. But TP was unable to work on CIAB and had to be started on locally. None of the UI tests would pass until the password was changed.
zrhoffman
approved these changes
Jul 27, 2020
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
- Ran TP UI tests, verified 72 out of 72 tests pass again
- Exposing port 443 in the TP CDN-in-a-Box Dockerfile is a definite improvement.
- Changing the TP UI tests default password to match the default CDN-in-a-Box default admin password is an improvement.
LGTM
mitchell852
added
Traffic Portal v1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR fixes a bug in Traffic_Portal's UI end-end testing. https://github.com/apache/trafficcontrol/pull/4908/files/e71e4255fc0c429ecdca0ffd3d1acd640abac4da#diff-97233245722ee5dad1b7499a628647ed
There isn't an issue number
It also updated the password in Traffic Portal's end-to-end/config.json file
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
webdriver-manager startprotractor config.jsfrom traffic_control/traffic_portal/test/end-to-end/ folder72 specs, 0 failuresIf this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information