Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

fix service category delete bug#4962

Merged
mitchell852 merged 2 commits intoapache:masterfrom
jehunte:sc-delete-bug
Aug 17, 2020
Merged

fix service category delete bug#4962
mitchell852 merged 2 commits intoapache:masterfrom
jehunte:sc-delete-bug

Conversation

@jehunte
Copy link
Contributor

@jehunte jehunte commented Aug 14, 2020

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

Traffic Portal

What is the best way to verify this PR?

Create a Service Category and verify that you can delete it

If this is a bug fix, what versions of Traffic Control are affected?

Next version to be released

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@ocket8888 ocket8888 added bug something isn't working as intended medium impact impacts a significant portion of a CDN, or has the potential to do so Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one and removed medium impact impacts a significant portion of a CDN, or has the potential to do so labels Aug 14, 2020
@mitchell852
Copy link
Member

mitchell852 commented Aug 14, 2020

@jehunte - looks good but sorry to do this to you. can you add documentation for the DELETE method of api/3.0/service_categories. You can follow this example: https://traffic-control-cdn.readthedocs.io/en/latest/api/v3/topologies.html#delete

@jehunte
Copy link
Contributor Author

jehunte commented Aug 17, 2020

@mitchell852 Added documentation!

Copy link
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mitchell852 mitchell852 merged commit 1ef3e4f into apache:master Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot delete Service Categories on TP

3 participants

Comments