This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Merged
Conversation
Adds ORT/atstccfg support for multiple server interfaces, a new feature in Traffic Control.
rob05c
added
new feature
ezelkow1
reviewed
Aug 28, 2020
Member
ezelkow1
left a comment
ezelkow1
left a comment
There was a problem hiding this comment.
still reviewing, just had these 2 small things so far. At least the majority of changes are related to changing to pointers. Also still have to get it running somewhere
ezelkow1
approved these changes
Aug 31, 2020
Member
ezelkow1
left a comment
ezelkow1
left a comment
There was a problem hiding this comment.
Tested on a test setup removing all DS's and re-adding and comparing parents and they were the same
Per PR review.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Multiple Interfaces to ORT.
Includes getting the right interface from the Server, as well as setting the records.config
outgoing_ipsetting to the Service Interface(s).This also refactors remap.config and parent.config, to use standard API objects. Those were already in the works and had a PR, and multi-interface support would cause huge conflicts, as well as much of the same code to review. A single PR both avoids conflicts and makes it less code to review.
No changelog, no interface change.
No docs, multi-interface servers is already documented.
Includes unit tests.
Manually tested, config generates the same before and after this change for our production servers, as well as our test environment with Topologies.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run unit tests.
Generate config with ORT before this change, build this and generate new config, diff and verify there are no semantic changes, except the additional record.config entry.
If this is a bug fix, what versions of Traffic Control are affected?
Not a bug fix.
The following criteria are ALL met by this PR
Additional Information