Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

added missing API tests for snapshot endpoints#5002

Merged
mitchell852 merged 3 commits intoapache:masterfrom
mattjackson220:snapshotApiTests
Sep 18, 2020
Merged

added missing API tests for snapshot endpoints#5002
mitchell852 merged 3 commits intoapache:masterfrom
mattjackson220:snapshotApiTests

Conversation

@mattjackson220
Copy link
Contributor

@mattjackson220 mattjackson220 commented Sep 1, 2020

What does this PR (Pull Request) do?

This PR adds in API tests that were missing for the snapshot endpoints for all API versions

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run the API tests for v1, v2 and v3 and verify that all are successful. Verify that all snapshot endpoints now have API test coverage

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

No docs, CHANGELOG, or data migrations included since this is just adding missing API tests

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@mattjackson220 mattjackson220 added tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops labels Sep 1, 2020
@mitchell852
Copy link
Member

@mattjackson220 - not sure if you want to kill 2 birds w/ one stone or a separate PR but this seems kinda related: #5007

@mattjackson220 mattjackson220 added the documentation related to documentation label Sep 3, 2020
Copy link
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitchell852 mitchell852 merged commit 3995be2 into apache:master Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation related to documentation tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No mention of monitoring.json in API documentation for generating a snapshot

2 participants