This repository was archived by the owner on Nov 24, 2025. It is now read-only.
New endpoint: Queue updates on the servers in a topology#5016
Merged
rawlinp merged 11 commits intoapache:masterfrom Sep 22, 2020
Merged
New endpoint: Queue updates on the servers in a topology#5016rawlinp merged 11 commits intoapache:masterfrom
rawlinp merged 11 commits intoapache:masterfrom
Conversation
zrhoffman
added
documentation
shamrickus
reviewed
Sep 8, 2020
shamrickus
reviewed
Sep 8, 2020
- Lengthen overline
shamrickus
approved these changes
Sep 8, 2020
Member
shamrickus
left a comment
shamrickus
left a comment
There was a problem hiding this comment.
Only looked at the docs/TP changes, the TO changes should be reviewed before merging
LGTM
zrhoffman
force-pushed
the
top-queue-updates
branch
from
2f0077f to
60ec814
Compare
Member
Author
|
Rebased to master |
zrhoffman
force-pushed
the
top-queue-updates
branch
from
444ae04 to
0aebf90
Compare
Member
Author
|
Fixed a merge conflict due to |
srijeet0406
reviewed
Sep 15, 2020
| ` | ||
| var err error | ||
| if _, err = tx.Exec(query, queue, topologyName, cdnId); err != nil { | ||
| err = fmt.Errorf("queueing updates: %s", err) |
Contributor
There was a problem hiding this comment.
Should this be err.Error() instead?
Member
Author
There was a problem hiding this comment.
Should it, as in will it not work unless it is err.Error()? fmt's reflection successfully casts error to string type because it only has 1 field, which is string type, so err works.
Contributor
|
Unit tests pass, API tests pass. |
srijeet0406
approved these changes
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
POST /topologies/{name}/queue_updateendpoint.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
The following criteria are ALL met by this PR