This repository was archived by the owner on Nov 24, 2025. It is now read-only.
GET service_categories returns 500#5026
Merged
zrhoffman merged 1 commit intoapache:masterfrom Sep 14, 2020
Merged
Conversation
srijeet0406
changed the title
zrhoffman
approved these changes
Sep 14, 2020
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
- GET /api/3.0/service_categories with IMS header returns 200 response
- Unit tests pass (the unit test failure is unrelated to this PR and I cannot reproduce it)
- API tests pass
- Code is formatted correctly
LGTM
zrhoffman
added
regression bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the unit tests and API tests and make sure they pass.
Make a call to
GET /api/3.0/service_categorieswith and without anIf-Modified-Sinceheader and make sure you get valid results (and no 500 error) on both occassions.If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information