This repository was archived by the owner on Nov 24, 2025. It is now read-only.
updated traffic_ops_ort.pl to use multistep mv for config shuffle#5034
Draft
MylesBock wants to merge 2 commits intoapache:masterfrom
Draft
updated traffic_ops_ort.pl to use multistep mv for config shuffle#5034MylesBock wants to merge 2 commits intoapache:masterfrom
MylesBock wants to merge 2 commits intoapache:masterfrom
Conversation
ocket8888
added
bug
* Replaced /bin/cp with /bin/mv and changed target to same wd as target with new suffix * Added error handling surrounding `system` use in that block * Added second step to mv old config to the same wd with `.old` suffix, then mv from `.new`
* Todo comments expanded * Whitespace adjusted to line multiline strings up a little better * Hopefully the traffic router action doesn't time out in this case?
MylesBock
force-pushed
the
4311/traffic-ops-ort-cp-to-mv
branch
from
9b6e278 to
39c08f2
Compare
mitchell852
removed
the
Traffic Ops ORT *DEPRECATED*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4311
Replaced /bin/cp with /bin/mv and changed target to same wd as target with new suffix
Added error handling surrounding
systemuse in that blockAdded second step to mv old config to the same wd with
.oldsuffix, then mv from.newFirst PR opened here, so may need guidance on how to test this
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Validate a new configuration can be generated and that the old can be supplanted via ORT
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information