GitHub Actions: Cache Maven dependencies#5036
Conversation
ocket8888
left a comment
There was a problem hiding this comment.
Clearly fixes CI because the actions worked
|
We should also be doing this for TP's node_modules dependencies, btw. |
|
I got on this topic last night and threw a few more things in the mix that may aid this job: https://github.com/MylesBock/trafficcontrol/runs/1129862202 Performs roughly the same caching of maven artifacts, adds a little finegrained control over |
|
Sorry, I didn't know anyone else was working on it (and should have made a GitHub issue before submitting a PR to fix). If you aren't there already, feel free to join #traffic_router on the Apache Traffic Control slack (there's an invite link in the docs), where we were discussing a fix. If you think it can be improved further, though, PRs are welcome.
I also opened #5042 to document that we don't cache NPM dependencies. |
What does this PR (Pull Request) do?
This will speed up building TR as well, which always takes the longest of any component to build on GitHub Actions
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Check the Traffic Router GitHub Actions result, since GHA is the only place experiencing rate limiting.
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR