Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix Traffic Ops looking for influxdb.conf in the wrong place#5107

Merged
rawlinp merged 3 commits intoapache:masterfrom
ocket8888:to/influxdb.conf-path-fix
Oct 13, 2020
Merged

Fix Traffic Ops looking for influxdb.conf in the wrong place#5107
rawlinp merged 3 commits intoapache:masterfrom
ocket8888:to/influxdb.conf-path-fix

Conversation

@ocket8888
Copy link
Contributor

What does this PR (Pull Request) do?

With this PR, Traffic Ops will look for influxdb.conf in ./conf/$MOJO_MODE/ if influxdb_conf_path is not given in cdn.conf and the MOJO_MODE environment variable is set to any non-empty string.

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Set MOJO_MODE, then start Traffic Ops from somewhere such that there is a valid influxdb.conf at ./conf/$MOJO_MODE/influxdb.conf, then verify that the therein contained was picked up by Traffic Ops by requesting some endpoint that needs Traffic Stats and watching the logs output.

If this is a bug fix, what versions of Traffic Control are affected?

  • 4.1.0
  • master

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops documentation related to documentation configuration related to configuration - not limited to any one component regression bug a bug in existing functionality introduced by a new version labels Oct 5, 2020
@ocket8888 ocket8888 requested a review from rawlinp October 13, 2020 21:15
Copy link
Contributor

@rawlinp rawlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rawlinp rawlinp merged commit 560a0bd into apache:master Oct 13, 2020
@ocket8888 ocket8888 deleted the to/influxdb.conf-path-fix branch October 13, 2020 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

configuration related to configuration - not limited to any one component documentation related to documentation regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Traffic Ops Golang isn't looking for influxdb.conf in the right place

2 participants