This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix ORT Topology Generation to Omit OFFLINE, Other CDNs, and MSO Origins without DeliveryServiceServers#5119
Merged
rawlinp merged 2 commits intoapache:masterfrom Oct 14, 2020
Conversation
rob05c
added
bug
rob05c
commented
Oct 7, 2020
lib/go-atscfg/parentdotconfig.go
Outdated
Member
Author
There was a problem hiding this comment.
It isn't strictly necessary to do this filtering. But it will make it easier to change ORT to use the origins table or any other DSS alternative in the future.
rob05c
force-pushed
the
fix-ort-topology-only-reported-cdn
branch
from
017213a to
55342c7
Compare
Fixes ORT generation for Topology DSes to omit parents that are not ONLINE or REPORTED, as well as parents assigned to other CDNs. Also fixes Topologies on MSO Delivery Services to consider Delivery Service Servers, and omit Origins not assigned to a DS.
rob05c
force-pushed
the
fix-ort-topology-only-reported-cdn
branch
from
55342c7 to
b8a1225
Compare
rob05c
force-pushed
the
fix-ort-topology-only-reported-cdn
branch
from
aa71e88 to
dd002a6
Compare
rawlinp
approved these changes
Oct 14, 2020
Contributor
rawlinp
left a comment
rawlinp
left a comment
There was a problem hiding this comment.
Looks good, checks passed, manual comparison testing went well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ORT generation for Topology DSes to omit parents that are
not ONLINE or REPORTED, as well as parents assigned to other CDNs.
Also fixes Topologies on MSO Delivery Services to consider
Delivery Service Servers, and omit Origins not assigned to a DS.
Includes tests.
No docs, no interface change.
No changelog, no interface change, and bug is not in an existing release.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run tests.
Run ORT with a Topology DS, with OFFLINE Mids in the Topology, and Mids in other CDNs in the Topology, and with MSO Delivery Services with assigned Origin Servers, and with Origin Servers belonging to other DSes which aren't assigned; verify OFFLINE and other-cdn mids are not added to parent.config, verify MSO origins are in parent.config, verify origins on other DSes are not on the DS parent.config line.
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information