Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Added User-Agent String to Traffic Router Log Output#5131

Merged
zrhoffman merged 4 commits intoapache:masterfrom
ARMmaster17:useragentstring
Oct 15, 2020
Merged

Added User-Agent String to Traffic Router Log Output#5131
zrhoffman merged 4 commits intoapache:masterfrom
ARMmaster17:useragentstring

Conversation

@ARMmaster17
Copy link
Contributor

What does this PR (Pull Request) do?

Requested by @smalenfant, adds User-Agent header string to log output from Traffic Router for each request.

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Router

What is the best way to verify this PR?

Pull and run CDN-in-a-Box and make a request against traffic router using the built-in VNC container (or your own custom solution). Check the console output of Traffic Router from the request and verify the that a field exists similar to uas="Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0".

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added Traffic Router related to Traffic Router new feature A new feature, capability or behavior labels Oct 12, 2020
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 comment about the changelog, everything else looks great.

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Unit tests pass
  • Integration tests pass
  • External tests pass

Confirmed the user agent shows up as expected in the logs.

@zrhoffman zrhoffman merged commit 31913d5 into apache:master Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new feature A new feature, capability or behavior Traffic Router related to Traffic Router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants