This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Added User-Agent String to Traffic Router Log Output#5131
Merged
zrhoffman merged 4 commits intoapache:masterfrom Oct 15, 2020
ARMmaster17:useragentstring
Merged
Added User-Agent String to Traffic Router Log Output#5131zrhoffman merged 4 commits intoapache:masterfrom ARMmaster17:useragentstring
zrhoffman merged 4 commits intoapache:masterfrom
ARMmaster17:useragentstring
Conversation
zrhoffman
suggested changes
Oct 15, 2020
Member
zrhoffman
left a comment
There was a problem hiding this comment.
Just 1 comment about the changelog, everything else looks great.
zrhoffman
approved these changes
Oct 15, 2020
Member
zrhoffman
left a comment
There was a problem hiding this comment.
- Unit tests pass
- Integration tests pass
- External tests pass
Confirmed the user agent shows up as expected in the logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Requested by @smalenfant, adds User-Agent header string to log output from Traffic Router for each request.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Pull and run CDN-in-a-Box and make a request against traffic router using the built-in VNC container (or your own custom solution). Check the console output of Traffic Router from the request and verify the that a field exists similar to
uas="Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0".The following criteria are ALL met by this PR