Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Added a --traffic_ops_insecure optional option to traffic_ops_ort.pl#5135

Merged
hbeatty merged 1 commit intoapache:4.1.xfrom
hbeatty:HB-update-ort-for-insecure-to_4.1.x
Oct 14, 2020
Merged

Added a --traffic_ops_insecure optional option to traffic_ops_ort.pl#5135
hbeatty merged 1 commit intoapache:4.1.xfrom
hbeatty:HB-update-ort-for-insecure-to_4.1.x

Conversation

@hbeatty
Copy link
Contributor

@hbeatty hbeatty commented Oct 11, 2020

What does this PR (Pull Request) do?

Added a --traffic_ops_insecure=<0|1> optional option to traffic_ops_ort.pl

The documentation refers to a Python version of traffic_ops_ort. I am not sure where the documentation for the Perl version is.

Backport of #5134

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Ops ORT

What is the best way to verify this PR?

Install ORT on a cache server in a CDN where Traffic Ops is using a self-signed cert.

If this is a bug fix, what versions of Traffic Control are affected?

This is not a bug fix.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@hbeatty hbeatty added new feature A new feature, capability or behavior backport an upstream change merged into an older release Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script labels Oct 11, 2020
@hbeatty hbeatty requested a review from rob05c October 11, 2020 17:29
@hbeatty hbeatty self-assigned this Oct 11, 2020
@hbeatty hbeatty merged commit 02bd287 into apache:4.1.x Oct 14, 2020
@hbeatty hbeatty deleted the HB-update-ort-for-insecure-to_4.1.x branch October 14, 2020 23:48
@rawlinp
Copy link
Contributor

rawlinp commented Oct 15, 2020

@hbeatty I would've merged this as a backport anyways, but generally it is the release manager's responsibility to merge backports into their release branch.

@rob05c
Copy link
Member

rob05c commented Oct 15, 2020

Yeah, just for future reference, the Release Manager "owns" the release branch, in this case 4.1.x. It's ok for someone to say "can I merge this" and them to say yes. But we're generally not supposed to merge anything into a release branch without the approval of the RM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport an upstream change merged into an older release new feature A new feature, capability or behavior Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants