Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Only run Last-Server-In-Cache Group validation when Cache Group has changed#5166

Merged
rawlinp merged 2 commits intoapache:masterfrom
zrhoffman:only-check-if-cg-changed
Oct 19, 2020
Merged

Only run Last-Server-In-Cache Group validation when Cache Group has changed#5166
rawlinp merged 2 commits intoapache:masterfrom
zrhoffman:only-check-if-cg-changed

Conversation

@zrhoffman
Copy link
Member

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run API tests or

  1. Make a Cache Group
  2. Make a Server
  3. Add the Server to the Cache Group
  4. Make a Topology
  5. Add the Server to the Topology
  6. Update the Server without changing anything

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests
  • Intended behavior is unchanged, no documentation necessary
  • Bugfix for a feature not yet in a release, no CHANGELOG.md entry necessary
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops regression bug a bug in existing functionality introduced by a new version labels Oct 17, 2020
@zrhoffman zrhoffman changed the title Only check if cg changed Only run Last-Server-In-Cache Group validation when Cache Group has changed Oct 17, 2020
Copy link
Contributor

@rawlinp rawlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks passed, code looks sound.

@rawlinp rawlinp merged commit 7c7d453 into apache:master Oct 19, 2020
@zrhoffman zrhoffman deleted the only-check-if-cg-changed branch October 19, 2020 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Last-Server-In-Cache Group validation runs when Cache Group has not changed

2 participants