This repository was archived by the owner on Nov 24, 2025. It is now read-only.
TP: converts delivery service requests table to ag-grid#5183
Merged
ocket8888 merged 14 commits intoapache:masterfrom Nov 2, 2020
Merged
TP: converts delivery service requests table to ag-grid#5183ocket8888 merged 14 commits intoapache:masterfrom
ocket8888 merged 14 commits intoapache:masterfrom
Conversation
mitchell852
added
Traffic Portal v1
mitchell852
force-pushed
the
dsr-ag-grid
branch
from
746b715 to
57afb10
Compare
mitchell852
commented
Oct 29, 2020
...p/src/common/modules/table/deliveryServiceRequests/TableDeliveryServiceRequestsController.js
Outdated
Show resolved
Hide resolved
ocket8888
suggested changes
Oct 29, 2020
ocket8888
reviewed
Oct 30, 2020
ocket8888
approved these changes
Nov 2, 2020
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
Checked it out, seems to work fine. Docs are complete, accurate, and build without error or warning.
ocket8888
pushed a commit
that referenced
this pull request
Nov 3, 2020
* converts delivery service requests table to ag-grid * adds back refresh * rearranging the context menu * removes strikethru from completed dsrs * changing colors * removes shadowing * removes column filter if column is hidden * adds changelog.md entry * handles error scenario when ds update fails * reverts bug fix * removes double click but still allows cell selection * adds documentation for new query param - createdAt * fixes docs for rfc reference * adds lastUpdated column and as default, hides lastUpdated and lastEditedBy columns (cherry picked from commit 9258b77)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Replaces the jquery datatables delivery services requests (DSR) table (slow) with the more performant ag-grid. Also, added the ability to order ds requests by createdAt date.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
The following criteria are ALL met by this PR
Additional Information