Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix 403 forbidden in deliveryservices_test#5214

Merged
zrhoffman merged 1 commit intoapache:masterfrom
srijeet0406:CDN-11112
Oct 28, 2020
Merged

Fix 403 forbidden in deliveryservices_test#5214
zrhoffman merged 1 commit intoapache:masterfrom
srijeet0406:CDN-11112

Conversation

@srijeet0406
Copy link
Contributor

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • Traffic Ops

What is the best way to verify this PR?

The bug was due to a bad merge, which is fixed in this PR. Follow the steps in #5203 and make sure the tests pass.

If this is a bug fix, what versions of Traffic Control are affected?

  • master

The following criteria are ALL met by this PR

  • This PR includes tests
  • I have explained why documentation is unnecessary
  • This PR does not include an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@ocket8888 ocket8888 added bug something isn't working as intended tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops labels Oct 28, 2020
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Confirmed that removing the err != nil check is valid, that err != nil check was not there as of f42709e~
  • Confirmed that API tests succeed when includeSystemTests is enabled

LGTM

@zrhoffman zrhoffman merged commit d7b817f into apache:master Oct 28, 2020
@zrhoffman
Copy link
Member

@ocket8888 since 5.0.x includes #4942, it should include #5214, too.

ocket8888 pushed a commit that referenced this pull request Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestDeliveryServices API test fails: 403 Forbidden

3 participants