This repository was archived by the owner on Nov 24, 2025. It is now read-only.
t3c should send atstccfg the default ATS configuration directory#5251
Merged
rob05c merged 1 commit intoapache:masterfrom Nov 6, 2020
Merged
t3c should send atstccfg the default ATS configuration directory#5251rob05c merged 1 commit intoapache:masterfrom
rob05c merged 1 commit intoapache:masterfrom
Conversation
to set the ATS configuration directory for config files that have a relative or not 'Path'. Also, this re-orders the rpm package check to occur before any config files are request from traffic ops.
jrushford
force-pushed
the
t3c_changes
branch
from
4e11c79 to
ab2a5f4
Compare
rob05c
added
bug
rob05c
approved these changes
Nov 6, 2020
Member
rob05c
left a comment
rob05c
left a comment
There was a problem hiding this comment.
Looks good! I manually tested, t3c drops all configs as-expected. Removed ATS, watched it default to /opt/trafficserver. Tested location params still place where their value is, custom --trafficserver-home places in that dir/etc/trafficserver as expected.
ocket8888
pushed a commit
to ocket8888/trafficcontrol
that referenced
this pull request
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR fixes a bug where t3c does not send the default ATS config
directory to atstccfg. The default ATS configuration directory is used
for config files that have a relative or nil 'Path'. Also, this re-orders the rpm
package check to occur before any config files are request from
traffic ops.
No issue was created because t3c doesn't have integration tests yet
and is not yet used in production. This problem was detected while
developing tests for t3c.
Which Traffic Control components are affected by this PR?
The following criteria are ALL met by this PR
t3c is not currently used in production and an integration test framework is still being
developed for it so this tests are forthcoming along with documentation and there is
no need to update the CHANGELOG at this time.
Additional Information