This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix LetsEncryptDnsChallengeWatcher config location#5280
Merged
rawlinp merged 3 commits intoapache:masterfrom Nov 13, 2020
shamrickus:tr/fix-le
Merged
Fix LetsEncryptDnsChallengeWatcher config location#5280rawlinp merged 3 commits intoapache:masterfrom shamrickus:tr/fix-le
rawlinp merged 3 commits intoapache:masterfrom
shamrickus:tr/fix-le
Conversation
rawlinp
added
bug
rawlinp
suggested changes
Nov 13, 2020
Contributor
rawlinp
left a comment
rawlinp
left a comment
There was a problem hiding this comment.
Code looks good, unit and integration tests pass. Just one formatting issue
traffic_router/core/src/main/webapp/WEB-INF/applicationContext.xml
Outdated
Show resolved
Hide resolved
rawlinp
approved these changes
Nov 13, 2020
ocket8888
pushed a commit
that referenced
this pull request
Nov 18, 2020
* Fix LE Watcher * Forgot Changelog * Use tabs Co-authored-by: Steve Hamrick <steve_hamrick@comcast.com> (cherry picked from commit bf10033)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This fixes the LEDnsChallengerWatcher when the cr-config file is not located at
/opt/traffic_router/db/cr-config.son.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure
/opt/traffic_router/db/cr-config.jsondoes not exist and run the TR tests.Alternatively, you can run this branch shamrickus/tr-int-test-2 and follow these instructions
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR