Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Update ORT to handle max_request_header_size#5465

Closed
jpappa200 wants to merge 7 commits intoapache:masterfrom
jpappa200:max_request_header
Closed

Update ORT to handle max_request_header_size#5465
jpappa200 wants to merge 7 commits intoapache:masterfrom
jpappa200:max_request_header

Conversation

@jpappa200
Copy link
Contributor

@jpappa200 jpappa200 commented Jan 25, 2021

What does this PR (Pull Request) do?

  • This PR closes Limit request_header_max_size per DS #5244 and will add a header rw to control max_haeder_request_size if the field in TP is not nil and greater than 0 . However, if the size added in TP exceeds the global setting, a header rw will be added with a comment that it is greater than the global setting and will be ignored.

Which Traffic Control components are affected by this PR?

  • Traffic Ops ORT

What is the best way to verify this PR?

Tested in CDN nightly lab. Updated ORT RPM on test cache. Update Max Request Header Size field in test delivery service and queue updates on an edge cache.

If this is a bug fix, what versions of Traffic Control are affected?

This is not a bug fix.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@mitchell852 mitchell852 added Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script new feature A new feature, capability or behavior labels Jan 26, 2021
@rob05c rob05c self-assigned this Feb 23, 2021
@jpappa200
Copy link
Contributor Author

This PR is obsolete due to changes in headerrewritedotconfig.go

@jpappa200 jpappa200 closed this Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new feature A new feature, capability or behavior Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limit request_header_max_size per DS

3 participants