Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add the Traffic Ops ORT requester.#5468

Merged
rob05c merged 1 commit intoapache:masterfrom
jrushford:to_update
Feb 3, 2021
Merged

Add the Traffic Ops ORT requester.#5468
rob05c merged 1 commit intoapache:masterfrom
jrushford:to_update

Conversation

@jrushford
Copy link
Contributor

@jrushford jrushford commented Jan 27, 2021

What does this PR (Pull Request) do?

As part of the ORT re-write from perl to go, the adds the Traffic Ops Requester as described
in the ORT re-write blueprint PR 4628

Which Traffic Control components are affected by this PR?

  • Traffic Ops ORT

What is the best way to verify this PR?

Read traffic_ops_ort/to_requester/README.md

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Once the ORT Integration tests PR is merged, integration tests will be added to
this Traffic Ops Requester.

@mitchell852 mitchell852 added Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script new feature A new feature, capability or behavior labels Jan 28, 2021
@dneuman64
Copy link
Contributor

@traeak is reviewing

@jrushford jrushford force-pushed the to_update branch 2 times, most recently from 1deac54 to 950c86c Compare February 3, 2021 16:55
@jrushford jrushford changed the title Add the Traffic Ops ORT requestor. Add the Traffic Ops ORT requester. Feb 3, 2021
Copy link
Contributor

@traeak traeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look well documented and reasonably consistent. Basic functionality was tested including environmental TO variables.

Copy link
Member

@rob05c rob05c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust @traeak 's approval, and besides this doesn't affect production yet.

@rob05c rob05c merged commit 82314b1 into apache:master Feb 3, 2021
@jrushford jrushford deleted the to_update branch February 18, 2021 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new feature A new feature, capability or behavior Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants