This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Adding atscfg overrides to insert the Release version in via string#5470
Merged
rob05c merged 6 commits intoapache:masterfrom Feb 3, 2021
ezelkow1:atscfg-atsver
Merged
Adding atscfg overrides to insert the Release version in via string#5470rob05c merged 6 commits intoapache:masterfrom ezelkow1:atscfg-atsver
rob05c merged 6 commits intoapache:masterfrom
ezelkow1:atscfg-atsver
Conversation
…uild hash of ATS, instead of the actual ATS version number This also adds atscfg and ort command line options for both the release version via string as well as a previous option to disable per line comments in parent.config
ocket8888
reviewed
Jan 27, 2021
rob05c
approved these changes
Feb 3, 2021
Member
rob05c
left a comment
There was a problem hiding this comment.
Looks good! Code looks good. I tested, worked as expected. Ran ORT as before, didn't insert via strings. Ran with --via_string_release, ATS version was added to records.config, requested ATS, observed ATS yum version in via header in response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
The release version can be a user definable build option of ATS, instead of the actual ATS version number. So being able to set this as the via string can be useful for both debug to get a specific build value that was in use as well as obfuscation of the ATS version in use
This also adds atscfg and ort command line options for both the release version via string as well as a previous option
to disable per line comments in parent.config
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run atstccfg with the
--via_string_releaseoption, or set that as an option in the crontab for ciab. Then check the via string output from a cache request in the headers and verify that it now shows the release value from the rpm instead of the ATS versionIf this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information