Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Adding atscfg overrides to insert the Release version in via string#5470

Merged
rob05c merged 6 commits intoapache:masterfrom
ezelkow1:atscfg-atsver
Feb 3, 2021
Merged

Adding atscfg overrides to insert the Release version in via string#5470
rob05c merged 6 commits intoapache:masterfrom
ezelkow1:atscfg-atsver

Conversation

@ezelkow1
Copy link
Member

What does this PR (Pull Request) do?

The release version can be a user definable build option of ATS, instead of the actual ATS version number. So being able to set this as the via string can be useful for both debug to get a specific build value that was in use as well as obfuscation of the ATS version in use

This also adds atscfg and ort command line options for both the release version via string as well as a previous option
to disable per line comments in parent.config

Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • Traffic Ops ORT

What is the best way to verify this PR?

Run atstccfg with the --via_string_release option, or set that as an option in the crontab for ciab. Then check the via string output from a cache request in the headers and verify that it now shows the release value from the rpm instead of the ATS version

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

…uild hash of ATS, instead of the actual ATS version number

This also adds atscfg and ort command line options for both the release version via string as well as a previous option
to disable per line comments in parent.config
@mitchell852 mitchell852 added Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script cdn-in-a-box related to the Docker-based CDN-in-a-Box system new feature A new feature, capability or behavior labels Jan 27, 2021
Copy link
Member

@rob05c rob05c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Code looks good. I tested, worked as expected. Ran ORT as before, didn't insert via strings. Ran with --via_string_release, ATS version was added to records.config, requested ATS, observed ATS yum version in via header in response.

@rob05c rob05c merged commit 41027d8 into apache:master Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cdn-in-a-box related to the Docker-based CDN-in-a-Box system new feature A new feature, capability or behavior Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants