This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Remove tm_path from CDN Snapshots#5475
Merged
zrhoffman merged 13 commits intoapache:masterfrom Feb 4, 2021
Merged
Conversation
ocket8888
force-pushed
the
to/remove-tm_url
branch
from
5e73337 to
cacd014
Compare
ocket8888
changed the title
ocket8888
added
new feature
mitchell852
reviewed
Jan 29, 2021
traffic_ops/app/db/migrations/2021012800000000_remove_tm_path.sql
Outdated
Show resolved
Hide resolved
ocket8888
force-pushed
the
to/remove-tm_url
branch
from
cacd014 to
2b8f37b
Compare
… snapshots taken)
tcfdev
reviewed
Feb 3, 2021
Collaborator
tcfdev
left a comment
tcfdev
left a comment
There was a problem hiding this comment.
Initial thoughts and questions regarding the code changes.
tcfdev
approved these changes
Feb 4, 2021
Collaborator
tcfdev
left a comment
tcfdev
left a comment
There was a problem hiding this comment.
Ran locally and performed verification steps. All pass. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Removes the
tm_pathproperty from thestatsproperty of CDN Snapshots.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Ensure that the API versions 3 and lower return the
tm_pathstring property in thestatsproperty of CDN Snapshots, and that API version 4 does not. Also, ensure that saved snapshots pre-existing in the database have that property removed when the migration in this PR is applied.The following criteria are ALL met by this PR