This repository was archived by the owner on Nov 24, 2025. It is now read-only.
GitHub Actions workflow to validate go.mod, go.sum, and vendor directory#5498
Merged
ocket8888 merged 12 commits intoapache:masterfrom Feb 4, 2021
Merged
GitHub Actions workflow to validate go.mod, go.sum, and vendor directory#5498ocket8888 merged 12 commits intoapache:masterfrom
ocket8888 merged 12 commits intoapache:masterfrom
Conversation
ocket8888
reviewed
Feb 4, 2021
infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
Outdated
Show resolved
Hide resolved
ocket8888
reviewed
Feb 4, 2021
ocket8888
approved these changes
Feb 4, 2021
Contributor
ocket8888
left a comment
There was a problem hiding this comment.
LGTM - also happy to get rid of some more references to the un-versioned client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
As a follow-up to #5229, this PR
go.mod,go.sum, and thevendordirectory have no uncommitted Git changes when modules are vendored.go.sumgo mod vendorto run successfully in the CiaB Traffic Opsintegrationservice's Dockerfile by including thev4-clientdirectory. Error fromgo mod vendorthat is fixed:Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Verify the GitHub Action is working as intended.
Check the result of the Check Go modules workflow at 0e54b99. The following steps are expected to have failed:
Check the result of the Check Go modules workflow at fb9f772. It is expected to succeed.
Run the TO API tests in CDN in a Box. On my computer, it took 55 minutes from the time when the API tests started running.
Run the Traffic Monitor unit tests in Docker
Run the Traffic Ops unit tests in Docker
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR