Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Update to DB migration server_id_primary_key.sql#5509

Merged
ocket8888 merged 1 commit intoapache:masterfrom
hbeatty:HB-update-server_id_primary_key.sql
Feb 11, 2021
Merged

Update to DB migration server_id_primary_key.sql#5509
ocket8888 merged 1 commit intoapache:masterfrom
hbeatty:HB-update-server_id_primary_key.sql

Conversation

@hbeatty
Copy link
Contributor

@hbeatty hbeatty commented Feb 10, 2021

What does this PR (Pull Request) do?

I was unable to run the dbadmin upgrade because this update was trying to add 2 primary keys (one for each schema).

I encountered this while trying to upgrade from 4.1.1 to 5.0.0.

  • Is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

I'm not sure how to test this. My DB has been around since the 1.x days. It has 2 schemas (traffic_ops and public). This SQL statement was trying to create a primary key in both schemas.

If this is a bug fix, what versions of Traffic Control are affected?

  • 4.1.1 -> 5.0.0 upgrade

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

I was unable to run the dbadmin upgrade because this update was trying to add 2 primary keys (one for each schema).

I encountered this while trying to upgrade from 4.1.1 to 5.0.0.
@hbeatty hbeatty self-assigned this Feb 10, 2021
@hbeatty hbeatty added bug something isn't working as intended database relating to setup/installation/structure of the Traffic Ops database install related to the installation process Traffic Ops related to Traffic Ops labels Feb 10, 2021
@hbeatty hbeatty requested a review from ocket8888 February 10, 2021 18:23
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked migration up/down, works without breaking, finished database works with TO on master (checked DS content available through CiaB).

@ocket8888 ocket8888 merged commit 46b4fd1 into apache:master Feb 11, 2021
@hbeatty hbeatty deleted the HB-update-server_id_primary_key.sql branch February 11, 2021 23:55
ocket8888 pushed a commit that referenced this pull request Feb 16, 2021
I was unable to run the dbadmin upgrade because this update was trying to add 2 primary keys (one for each schema).

I encountered this while trying to upgrade from 4.1.1 to 5.0.0.

Co-authored-by: Hank Beatty <hbeatty@dev4.atl-priv.kabletown.test>
(cherry picked from commit 46b4fd1)
@zrhoffman zrhoffman added this to the 5.1.0 milestone Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended database relating to setup/installation/structure of the Traffic Ops database install related to the installation process Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants