This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Merged
Conversation
mattjackson220
added
Traffic Ops
ocket8888
reviewed
Feb 11, 2021
ocket8888
reviewed
Feb 16, 2021
traffic_ops/traffic_ops_golang/deliveryservice/autorenewcerts.go
Outdated
Show resolved
Hide resolved
ocket8888
approved these changes
Feb 16, 2021
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
This LGTM; I confirmed the async job takes off (though not successfully) in CDN-in-a-Box, and since it's plugging into existing, working ACME logic to do anything more I'm confident it actually works in an environment with a working ACME provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR updates the certificate autorenewal script to include ACME providers (previously only did Let's Encrypt)
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Set up the necessary information in cdn.conf to allow automatic renewals
Make sure you have delivery services that have ACME certificates (and other types as well for testing)
Do a POST against the
acme_autorenewendpoint or put in the username and password and setup the cron job to runVerify that all expiring certs for ACME and Let's Encrypt are renewed and a summary email is sent if that is setup
Verify that docs build and look good
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Tests are not included since this is entirely dependent on 3rd parties
Additional Information