This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Reorder SQL migrations to fix some upgrade issues#5528
Merged
rawlinp merged 1 commit intoapache:masterfrom Feb 16, 2021
hbeatty:HB-fix-sql-migrations-order_master
Merged
Reorder SQL migrations to fix some upgrade issues#5528rawlinp merged 1 commit intoapache:masterfrom hbeatty:HB-fix-sql-migrations-order_master
rawlinp merged 1 commit intoapache:masterfrom
hbeatty:HB-fix-sql-migrations-order_master
Conversation
This moves some SQL migrations past the last one in 5.0.x that were not in the 4.1.x and 5.0.x branch.
Contributor
|
Ok, once this is merged it can be backported to 5.1.x, so we don't need #5528. |
Contributor
|
Yeah, I can do that for you. No need of a separate PR |
Contributor
Author
|
Just curious what the difference is? |
Contributor
|
By cherrypicking, we include the original commit hash from master by using the |
rawlinp
approved these changes
Feb 16, 2021
Contributor
rawlinp
left a comment
There was a problem hiding this comment.
LGTM, DB upgrades from 2020110200000000_add_service_category_deleted.sql (first migration script in 5.0) to the latest and downgrades back successfully.
ocket8888
pushed a commit
that referenced
this pull request
Feb 16, 2021
This moves some SQL migrations past the last one in 5.0.x that were not in the 4.1.x and 5.0.x branch. (cherry picked from commit 1fc56ce)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This moves some SQL migrations past the last one in 5.0.x that were not in the 4.1.x and 5.0.x branch.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Do a DB upgrade from 5.0.0 to 5.1.0
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR