This repository was archived by the owner on Nov 24, 2025. It is now read-only.
added status endpoint for async tasks#5544
Merged
ocket8888 merged 5 commits intoapache:masterfrom Mar 1, 2021
Merged
Conversation
ocket8888
reviewed
Feb 18, 2021
Contributor
ocket8888
left a comment
There was a problem hiding this comment.
Code all looks fine at a glance. Still need to test
traffic_ops/traffic_ops_golang/deliveryservice/autorenewcerts.go
Outdated
Show resolved
Hide resolved
ocket8888
reviewed
Feb 24, 2021
ocket8888
reviewed
Feb 26, 2021
Contributor
ocket8888
left a comment
There was a problem hiding this comment.
This looks ready for testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR adds an endpoint for status on asynchronous tasks and applies it to the ACME autorenewal endpoint
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Kick off an ACME autorenewal job and verify that it gives you a status endpoint to check
Verify that the endpoint is updated with the correct status as the autorenewal runs
Verify that the docs build and look good
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information