This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix atscfg Service Category Header to be Internal#5657
Merged
dneuman64 merged 1 commit intoapache:masterfrom Mar 19, 2021
Conversation
78ba0bf to
4043c01
Compare
alficles
approved these changes
Mar 19, 2021
Contributor
alficles
left a comment
There was a problem hiding this comment.
This looks good. It's a pretty simple change. I would note that this is a security improvement when origins are configured to respond to TRACE requests. (They generally shouldn't be.) Previously, these categories were leaked publically in that case. For most use cases, this probably isn't a huge risk, but this is an improvement in any case.
dsouza93
approved these changes
Mar 19, 2021
dsouza93
left a comment
There was a problem hiding this comment.
I tested this as well for what its worth. It looks good to me
ocket8888
pushed a commit
that referenced
this pull request
Mar 19, 2021
(cherry picked from commit cfe87f7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the TC Service Category header to be internal to ATS, and not sent by ATS in HTTP requests or responses.
Docs already exist for Service Category.
No changelog, no interface change.
Tested by existing Service Category Header Rewrite tests. I also manually tested, verified the
@header is not sent by ATS, and verified the header rewrite is created for both Edges and Mids.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run unit tests.
Generate config, verify header rewrites are prefixed with
@to make them internal to ATS. Run ATS, verify header writes are not passed upstream or downstream and are logged if an appropriatesvc=%<{@CDN_SVC}cqh>log field exists.If this is a bug fix, what versions of Traffic Control are affected?
masterThe following criteria are ALL met by this PR
Additional Information