Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix atscfg Service Category Header to be Internal#5657

Merged
dneuman64 merged 1 commit intoapache:masterfrom
rob05c:fix-atscfg-header-rewrite-injection-plus-internal-service-category-header
Mar 19, 2021
Merged

Fix atscfg Service Category Header to be Internal#5657
dneuman64 merged 1 commit intoapache:masterfrom
rob05c:fix-atscfg-header-rewrite-injection-plus-internal-service-category-header

Conversation

@rob05c
Copy link
Member

@rob05c rob05c commented Mar 19, 2021

Fixes the TC Service Category header to be internal to ATS, and not sent by ATS in HTTP requests or responses.

Docs already exist for Service Category.
No changelog, no interface change.
Tested by existing Service Category Header Rewrite tests. I also manually tested, verified the @ header is not sent by ATS, and verified the header rewrite is created for both Edges and Mids.

  • This PR fixes #REPLACE_ME OR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Ops ORT

What is the best way to verify this PR?

Run unit tests.
Generate config, verify header rewrites are prefixed with @ to make them internal to ATS. Run ATS, verify header writes are not passed upstream or downstream and are logged if an appropriate svc=%<{@CDN_SVC}cqh> log field exists.

If this is a bug fix, what versions of Traffic Control are affected?

master

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@rob05c rob05c added bug something isn't working as intended Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script labels Mar 19, 2021
@rob05c rob05c added this to the 5.1.1 milestone Mar 19, 2021
@rob05c rob05c force-pushed the fix-atscfg-header-rewrite-injection-plus-internal-service-category-header branch from 78ba0bf to 4043c01 Compare March 19, 2021 15:46
Copy link
Contributor

@alficles alficles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It's a pretty simple change. I would note that this is a security improvement when origins are configured to respond to TRACE requests. (They generally shouldn't be.) Previously, these categories were leaked publically in that case. For most use cases, this probably isn't a huge risk, but this is an improvement in any case.

Copy link

@dsouza93 dsouza93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this as well for what its worth. It looks good to me

@dneuman64 dneuman64 merged commit cfe87f7 into apache:master Mar 19, 2021
ocket8888 pushed a commit that referenced this pull request Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants