Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix TODB tests when providing initial DB dump to test with#5672

Merged
zrhoffman merged 1 commit intoapache:masterfrom
rawlinp:fix-todb-test-dump
Mar 23, 2021
Merged

Fix TODB tests when providing initial DB dump to test with#5672
zrhoffman merged 1 commit intoapache:masterfrom
rawlinp:fix-todb-test-dump

Conversation

@rawlinp
Copy link
Contributor

@rawlinp rawlinp commented Mar 23, 2021

What does this PR (Pull Request) do?

Fixes a new issue w/ the TODB tests when providing an initial database dump file. This test feature was accidentally broken in the conversion to postgres 13.2: #5630

Which Traffic Control components are affected by this PR?

  • Traffic Ops DB tests

What is the best way to verify this PR?

NOTE: the TODB postgres version that produces the TO DB dump should be 13.2. If it's 9.6, the test will fail because you can't restore a 9.6 DB dump into a 13.2 DB. If you use CIAB to get the TO dbdump, it should work, since CIAB now uses 13.2.

cd traffic_ops_db/test/docker
# get a DB dump from TO via /api/3.0/dbdump, put the dump file in ./initdb.d/
docker-compose build
docker-compose up --exit-code-from trafficops-db-admin

If this is a bug fix, what versions of Traffic Control are affected?

  • master

The following criteria are ALL met by this PR

  • This PR includes tests
  • test fix, no docs necessary
  • unreleased bug, no changelog necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@rawlinp rawlinp added bug something isn't working as intended tests related to tests and/or testing infrastructure database relating to setup/installation/structure of the Traffic Ops database labels Mar 23, 2021
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as db tests pass now using a 13.2 dump from CDN in a Box, but it would be nice to be able to test a PG 9.6 dump in PG 13.2.

@zrhoffman zrhoffman merged commit bd9e54e into apache:master Mar 23, 2021
@rawlinp rawlinp deleted the fix-todb-test-dump branch March 23, 2021 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended database relating to setup/installation/structure of the Traffic Ops database tests related to tests and/or testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants