This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix TODB tests when providing initial DB dump to test with#5672
Merged
zrhoffman merged 1 commit intoapache:masterfrom Mar 23, 2021
Merged
Fix TODB tests when providing initial DB dump to test with#5672zrhoffman merged 1 commit intoapache:masterfrom
zrhoffman merged 1 commit intoapache:masterfrom
Conversation
zrhoffman
approved these changes
Mar 23, 2021
Member
zrhoffman
left a comment
There was a problem hiding this comment.
Approving as db tests pass now using a 13.2 dump from CDN in a Box, but it would be nice to be able to test a PG 9.6 dump in PG 13.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Fixes a new issue w/ the TODB tests when providing an initial database dump file. This test feature was accidentally broken in the conversion to postgres 13.2: #5630
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
NOTE: the TODB postgres version that produces the TO DB dump should be 13.2. If it's 9.6, the test will fail because you can't restore a 9.6 DB dump into a 13.2 DB. If you use CIAB to get the TO dbdump, it should work, since CIAB now uses 13.2.
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR