Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add a Federation to the Ansible Dataset Loader#5685

Merged
jhg03a merged 25 commits intoapache:masterfrom
zrhoffman:federation
Apr 14, 2021
Merged

Add a Federation to the Ansible Dataset Loader#5685
jhg03a merged 25 commits intoapache:masterfrom
zrhoffman:federation

Conversation

@zrhoffman
Copy link
Member

@zrhoffman zrhoffman commented Mar 29, 2021

What does this PR (Pull Request) do?

  • This PR adds tasks to the dataset_loader to
    • Create a Federation
    • Assign a User to the Federation
    • Assign a Delivery Service to the Federation
    • Create Federation Resolvers
    • Assign Federation Resolvers to the Federation
  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Ansible roles

What is the best way to verify this PR?

Build an Apache Traffic Control environment using Ansible roles.

The following criteria are ALL met by this PR

  • No testing framework exists for the Ansible roles yet
  • Existing documentation is sufficient
  • This PR includes an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@zrhoffman zrhoffman added configuration related to configuration - not limited to any one component automation related to automated testing/deployment/packaging etc. labels Mar 29, 2021
@zrhoffman zrhoffman force-pushed the federation branch 2 times, most recently from ee7c9eb to 3b409d8 Compare April 6, 2021 01:51
@zrhoffman zrhoffman requested a review from jhg03a April 6, 2021 02:29
Copy link
Contributor

@jhg03a jhg03a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a deeper issue with the loops on federation creation. You need a double loop for handling the list of federations and list of delegations. You can use the product filter combine the two and vars to make it far more friendly.

@zrhoffman zrhoffman force-pushed the federation branch 2 times, most recently from ebab1dd to 8e95362 Compare April 12, 2021 14:48
@zrhoffman
Copy link
Member Author

Rebased to resolve a merge conflict in the changelog.

@zrhoffman zrhoffman requested a review from jhg03a April 12, 2021 15:10
@zrhoffman zrhoffman requested a review from jhg03a April 12, 2021 22:28
@zrhoffman zrhoffman requested a review from jhg03a April 12, 2021 22:36
@zrhoffman
Copy link
Member Author

Rebased onto master.

Copy link
Contributor

@jhg03a jhg03a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functional

@jhg03a jhg03a merged commit 1dc6a06 into apache:master Apr 14, 2021
@zrhoffman zrhoffman deleted the federation branch April 21, 2021 22:14
@zrhoffman zrhoffman added the ansible Related to the Ansible roles label May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ansible Related to the Ansible roles automation related to automated testing/deployment/packaging etc. configuration related to configuration - not limited to any one component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants