Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Replace uses of 'require' with 'import'#5687

Merged
zrhoffman merged 8 commits intoapache:masterfrom
ocket8888:tp/integration-tests/import-not-require
Apr 2, 2021
Merged

Replace uses of 'require' with 'import'#5687
zrhoffman merged 8 commits intoapache:masterfrom
ocket8888:tp/integration-tests/import-not-require

Conversation

@ocket8888
Copy link
Contributor

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

This PR replaces uses of require in the TP integration tests with import statements.

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Verify the test actions pass.

The following criteria are ALL met by this PR

  • This PR includes tests
  • Documentation is unnecessary
  • An update to CHANGELOG.md is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added Traffic Portal v1 related to Traffic Portal version 1 tests related to tests and/or testing infrastructure tech debt rework due to choosing easy/limited solution labels Mar 29, 2021
@shamrickus
Copy link
Member

Changes look good to me, the action failure doesn't actually have any real issues from what I can tell. Once it passes I'll approve.

@ocket8888 ocket8888 force-pushed the tp/integration-tests/import-not-require branch from 0ae1ce5 to 2bbe2b0 Compare April 2, 2021 17:26
Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zrhoffman zrhoffman merged commit 5784d8e into apache:master Apr 2, 2021
@ocket8888 ocket8888 deleted the tp/integration-tests/import-not-require branch April 2, 2021 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tech debt rework due to choosing easy/limited solution tests related to tests and/or testing infrastructure Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants