Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Except OSError in Python Postinstall#5692

Merged
ocket8888 merged 5 commits intoapache:masterfrom
zrhoffman:download-maxmind
Mar 30, 2021
Merged

Except OSError in Python Postinstall#5692
ocket8888 merged 5 commits intoapache:masterfrom
zrhoffman:download-maxmind

Conversation

@zrhoffman
Copy link
Member

What does this PR (Pull Request) do?

  • This PR avoids AttributeError: 'module' object has no attribute 'SubprocessError' in Python 2 if an OSError is thrown (e.g., if the download_tool path does not exit)
  • This PR changes the MaxMind database download tool from wget to curl
  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Ops (Python Postinstall script)

What is the best way to verify this PR?

  • Run the Postinstall unit tests
  • Run CDN in a Box under CentOS 7 with the answer to Download Maxmind Database? in input.json changed to "yes", make sure Traffic Ops starts

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests
  • Bugfix, documentation is unnecessary
  • An update to CHANGELOG.md is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops regression bug a bug in existing functionality introduced by a new version install related to the installation process labels Mar 30, 2021
wget is not included by default in CentOS 7 or 8
@zrhoffman zrhoffman changed the title Use curl to download the MaxMind database, not wget Use curl to download the MaxMind database, not wget Mar 30, 2021
@zrhoffman zrhoffman requested a review from ocket8888 March 30, 2021 19:16
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, no breaking changes

@ocket8888 ocket8888 merged commit a2b0ae8 into apache:master Mar 30, 2021
@zrhoffman zrhoffman changed the title Use curl to download the MaxMind database, not wget Except OSError in Python Postinstall Mar 30, 2021
@zrhoffman zrhoffman deleted the download-maxmind branch March 30, 2021 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

install related to the installation process regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants