This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Add goose to the PATH and log to stdout#5693
Merged
ocket8888 merged 6 commits intoapache:masterfrom Mar 31, 2021
Merged
Conversation
goose to the PATH and use Popen.communicate() to get process output
goose to the PATH and use Popen.communicate() to get process outputgoose to the PATH and log to stdout
793568e to
3712949
Compare
ocket8888
approved these changes
Mar 31, 2021
Contributor
ocket8888
left a comment
There was a problem hiding this comment.
Tests still pass, showing that logging to stdout - for an interactive program, for some reason - is working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Adds
/opt/traffic_ops/app/binto thePATHby sourcing/etc/profile.d/traffic_ops.sh.Makes the Python implementation of Postinstall log to stdout, not stderr, because that is what the Perl version does
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR