Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Switch goose provider to github.com/kevinburke/goose#5699

Merged
ocket8888 merged 3 commits intoapache:masterfrom
zrhoffman:github.com/kevinburke/goose
Apr 14, 2021
Merged

Switch goose provider to github.com/kevinburke/goose#5699
ocket8888 merged 3 commits intoapache:masterfrom
zrhoffman:github.com/kevinburke/goose

Conversation

@zrhoffman
Copy link
Member

@zrhoffman zrhoffman commented Apr 1, 2021

What does this PR (Pull Request) do?

This PR switched our goose provider from bitbucket.org/liamstask/goose/cmd/goose to github.com/kevinburke/goose, which is maintained (84 commits made by the forker between 2016-04-10 and 2021-02-22). For us, it is a drop-in replacement: It removes Go migration mode, which is fine because we no longer use it. Also, it is still MIT-licensed.

Which Traffic Control components are affected by this PR?

  • Traffic Ops migration tool

What is the best way to verify this PR?

  • Run CDN in a Box. If it runs successfully, then the migrations succeeded
  • Test our db/admin commands with the new goose provider:
    • db/admin -env production upgrade
    • db/admin -env production migrate
    • db/admin -env production down
    • db/admin -env production redo
    • db/admin -env production status
    • db/admin -env production dbversion

The following criteria are ALL met by this PR

  • Existing tests are sufficient
  • This PR includes documentation
  • This PR includes an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops database relating to setup/installation/structure of the Traffic Ops database improvement The functionality exists but it could be improved in some way. dependencies Pull requests that update a dependency file labels Apr 1, 2021
@zrhoffman zrhoffman force-pushed the github.com/kevinburke/goose branch 3 times, most recently from eb72d4a to 0ba7a5d Compare April 3, 2021 02:54
@zrhoffman zrhoffman force-pushed the github.com/kevinburke/goose branch from 5f44d7b to 278e38c Compare April 13, 2021 20:56
@zrhoffman
Copy link
Member Author

Rebased to resolve a merge conflict in the changelog

@rimashah25
Copy link
Contributor

LGTM.. Tested with CIAB and all the commands wrt production env ran successfully.

@ocket8888 ocket8888 merged commit 8ede898 into apache:master Apr 14, 2021
@zrhoffman zrhoffman deleted the github.com/kevinburke/goose branch April 21, 2021 22:15
@rawlinp rawlinp mentioned this pull request Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

database relating to setup/installation/structure of the Traffic Ops database dependencies Pull requests that update a dependency file improvement The functionality exists but it could be improved in some way. Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants