This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Add topologies test to integration test suite in TP#5700
Merged
ocket8888 merged 18 commits intoapache:masterfrom May 14, 2021
Merged
Add topologies test to integration test suite in TP#5700ocket8888 merged 18 commits intoapache:masterfrom
ocket8888 merged 18 commits intoapache:masterfrom
Conversation
ocket8888
added
new feature
ocket8888
reviewed
Apr 1, 2021
traffic_portal/test/integration/PageObjects/TopologiesPage.po.ts
Outdated
Show resolved
Hide resolved
traffic_portal/test/integration/PageObjects/TopologiesPage.po.ts
Outdated
Show resolved
Hide resolved
traffic_portal/test/integration/PageObjects/TopologiesPage.po.ts
Outdated
Show resolved
Hide resolved
traffic_portal/test/integration/PageObjects/TopologiesPage.po.ts
Outdated
Show resolved
Hide resolved
ocket8888
reviewed
Apr 2, 2021
added 8 commits
April 8, 2021 12:00
Contributor
Author
|
@ocket8888 I fixed all the comment and change the tests to new format. |
ocket8888
reviewed
Apr 22, 2021
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
Why was the package-lock.json file changed? It doesn't look like you actually added or removed any dependencies, since package.json was unchanged
traffic_portal/test/integration/PageObjects/TopologiesPage.po.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Finish fixing test for Docker environment |
ocket8888
reviewed
Apr 23, 2021
ocket8888
reviewed
Apr 29, 2021
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
I've heard other people had problems trying to use inherited methods instead of new BasePae instances; if you can't get it to work then just don't worry about it. It's something I can look into in my own time if it bothers me that much and isn't trivial to do.
added 2 commits
May 6, 2021 15:47
This reverts commit 6573b20.
Contributor
Author
|
Yeah, look like when I revert back to basePage it work. I will figure out why the basePage fail and do on other PR. |
ocket8888
approved these changes
May 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR created to add Topologies test base to the integration tests suite. More test will be added to this base.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
In traffic_portal/integration directory, run the traffic portal tests and make sure all the test pass.
Change the spec name to "specs/Topologies.spec.js" in config.ts file to run the specific tests.
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information