Separate Makefile targets for relative and absolute RPM paths#5703
Separate Makefile targets for relative and absolute RPM paths#5703ocket8888 merged 2 commits intoapache:masterfrom
Conversation
|
For the record, after #5653 you can still |
Not with the same command, I can't. This is what I get: [user@computer cdn-in-a-box]$ make traffic_ops/traffic_ops.rpm
make: *** No rule to make target 'traffic_ops/traffic_ops.rpm'. Stop.
|
|
What's your |
Yes, but remove I'm using GNU Make 4.3 |
|
oh, you're right. Man, that's weird... |
fc200a5 to
49f6884
Compare
|
Force-pushed to reword the commit message |
ocket8888
left a comment
There was a problem hiding this comment.
This works fine, and if there are any negative consequences to having multiple (identical) recipes for the same file, I can't think what they are.
What does this PR (Pull Request) do?
Before #5653, you could build a single RPM by running
make cache/traffic_ops_ort.rpmormake traffic_monitor/traffic_monitor.rpm, etc. and these Makefile targets were available to shell completion.As of #5653, no RPM targets are completable in the shell and the only completable targets are the phony ones:
all,build-builders,clean,debug,native,nearly-all,pull-builders, andvery-clean.This PR re-adds completion for those relative RPM targets but does not add them to the
alltarget.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
In the CDN in a Box directory:
maketo verify that thealltarget still worksmake traffic_ops/traffic_ops.rpmand verify that the RPM ends up atinfrastructure/cdn-in-a-box/traffic_ops/traffic_ops.rpmIn the main project directory:
make -f infrastructure/cdn-in-a-box/Makefile traffic_ops/traffic_ops.rpmand verify that the RPM ends up atinfrastructure/cdn-in-a-box/traffic_ops/traffic_ops.rpmand nottraffic_ops/traffic_ops.rpmIf this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information