This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fixed GET api/3.1/cdns/routing endpoint to avoid incorrect success response (return all zeros) #5709
Merged
zrhoffman merged 4 commits intoapache:masterfrom Apr 5, 2021
Merged
Conversation
…eturning incorrect err value.
Update CHANGELOG.md Removed unnecessary new lines
rawlinp
reviewed
Apr 2, 2021
...re/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/router/StatTracker.java
Outdated
Show resolved
Hide resolved
mitchell852
added
Traffic Ops
mattjackson220
approved these changes
Apr 5, 2021
Contributor
mattjackson220
left a comment
mattjackson220
left a comment
There was a problem hiding this comment.
Looks good to me! tests pass and it should fix the issue! nice!
zrhoffman
suggested changes
Apr 5, 2021
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
Fixed GET api/3.1/cdns/routing endpoint
Since it gets written to the git history, would you please edit the title to describe what issue with the /api/3.1/cdns/routing endpoint is fixed by this PR?
rawlinp
approved these changes
Apr 5, 2021
Contributor
rawlinp
left a comment
rawlinp
left a comment
There was a problem hiding this comment.
LGTM once more details are included in the title as @zrhoffman suggests.
rimashah25
changed the title
rimashah25
changed the title
rimashah25
changed the title
zrhoffman
approved these changes
Apr 5, 2021
ocket8888
pushed a commit
that referenced
this pull request
Apr 7, 2021
…sponse (return all zeros) (#5709) * Added debug statements * Removed debug fmt statements and updated the return error as it was returning incorrect err value. * Updated TR's stat tracker to include long int Update CHANGELOG.md Removed unnecessary new lines * Updated TR's stat tracker to include long int-1 (cherry picked from commit b31db78)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Test GET API endpoint: api/3.1/cdns/routing against CIAB or local TR and if TR is not up an running or has any other issue, one should see the right error response and http code.
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information
Logic didn't change, hence there was no test or documentation added.