This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Combine CDN in a Box Dockerfiles using build stage targets where possible#5710
Merged
rawlinp merged 17 commits intoapache:masterfrom Apr 16, 2021
Merged
Combine CDN in a Box Dockerfiles using build stage targets where possible#5710rawlinp merged 17 commits intoapache:masterfrom
rawlinp merged 17 commits intoapache:masterfrom
Conversation
0d03f75 to
c62fa61
Compare
c62fa61 to
fa69866
Compare
tcfdev
reviewed
Apr 15, 2021
Collaborator
tcfdev
left a comment
There was a problem hiding this comment.
Here's a few thoughts and notes based on reading the changes. I'm working on validating functionality separately.
Collaborator
|
Confirmed debugging possible in Goland and VSCode. |
tcfdev
approved these changes
Apr 16, 2021
Collaborator
tcfdev
left a comment
There was a problem hiding this comment.
Code reviewed and functionality tested. LGTM!
Approved!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Currently, if you try to build the
trafficmonitor-debug,trafficops-debug, andtrafficstats-debugimages without thetrafficmonitor,trafficops, andtrafficstatsexisting,it will fail to build with an error like
because you need to build those images first. You can get around that by simply attempting to build everything twice:
But updating RPMs in the debug images is still annoying because it requires building everything twice in this way. This PR fixes that behavior.
This PR
Makes the Traffic Monitor, Traffic Ops, and Traffic Ops debug images build stage targets within the non-debug Dockerfiles
Removes the
trafficmonitor-nondebug,trafficops-nondebug, andtrafficstats-nondebugservices from thedocker-compose.debugging.ymlcompose fileMakes
edgebuild theedgetarget ofcache/Dockerfileand makesmid-01andmid-02build themidtarget ofcache/DockerfileAdds the ability to debug the CDN in a Box enroller
This PR is not related to any Issue
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Untag the
trafficmonitor,trafficops, andtrafficstatsimages and then verify that runningsucceeds
Following the debugging documentation, set a breakpoint in
enroller.goand try to hit itIf this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR