This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Traffic Portal integration tests strict compilation mode#5711
Merged
mattjackson220 merged 8 commits intoapache:masterfrom Apr 7, 2021
Merged
Traffic Portal integration tests strict compilation mode#5711mattjackson220 merged 8 commits intoapache:masterfrom
mattjackson220 merged 8 commits intoapache:masterfrom
Conversation
ef64e22 to
c6614a2
Compare
shamrickus
approved these changes
Apr 7, 2021
Member
shamrickus
left a comment
There was a problem hiding this comment.
LGTM - really like the changes to no longer using try/catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR enables certain strict compilation options for the Traffic Portal integration test. Specifically, it sets:
{ "strict": true, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitThis": true }It does not, however, enable the
noImplicityAnycompiler option, because the test data is not currently type-safe, and changing that would be a multi-thousand-line change in its own right.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Ensure the TP integration tests compile, run, and pass.
The following criteria are ALL met by this PR