Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Traffic Portal integration tests strict compilation mode#5711

Merged
mattjackson220 merged 8 commits intoapache:masterfrom
ocket8888:tp/integration-tests/strict-mode
Apr 7, 2021
Merged

Traffic Portal integration tests strict compilation mode#5711
mattjackson220 merged 8 commits intoapache:masterfrom
ocket8888:tp/integration-tests/strict-mode

Conversation

@ocket8888
Copy link
Contributor

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

This PR enables certain strict compilation options for the Traffic Portal integration test. Specifically, it sets:

{
    "strict": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "noImplicitThis": true
}

It does not, however, enable the noImplicityAny compiler option, because the test data is not currently type-safe, and changing that would be a multi-thousand-line change in its own right.

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Ensure the TP integration tests compile, run, and pass.

The following criteria are ALL met by this PR

  • This PR includes tests
  • Documentation is unnecessary
  • An update to CHANGELOG.md is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added Traffic Portal v1 related to Traffic Portal version 1 tests related to tests and/or testing infrastructure tech debt rework due to choosing easy/limited solution labels Apr 2, 2021
@ocket8888 ocket8888 force-pushed the tp/integration-tests/strict-mode branch from ef64e22 to c6614a2 Compare April 6, 2021 22:31
Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - really like the changes to no longer using try/catch

@mattjackson220 mattjackson220 merged commit 78bfb5c into apache:master Apr 7, 2021
@ocket8888 ocket8888 deleted the tp/integration-tests/strict-mode branch April 7, 2021 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tech debt rework due to choosing easy/limited solution tests related to tests and/or testing infrastructure Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants