This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Merged
Conversation
report a malformed config when a plugin uses a long option parameter in a @pparam field.
rob05c
approved these changes
Apr 9, 2021
Member
rob05c
left a comment
There was a problem hiding this comment.
Looks good! Code looks good. ORT Integration Tests pass. I manually ran the plugin_verifier, it succeeds, false positives are gone.
Member
|
Odd, I thought all checks passed. But it looks like they didn't run at all? Well, I fixed #5734 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This fixes a bug in the plugin_verifier so that it does notreport a malformed config when a plugin uses a long option
parameter in a @pparam field.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
See the traffic_ops_ort/plugin_verifier/README.md and execute the
plugin_verifier against a copy of the remap.config which has entries
for the cachkey.so plugin using long options in its @pparam fields.
You should not see any errors.
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information
None