Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

ORT plugin_verifier bug fix#5716

Merged
rob05c merged 1 commit intoapache:masterfrom
jrushford:plugin_verifier_bug_fix
Apr 9, 2021
Merged

ORT plugin_verifier bug fix#5716
rob05c merged 1 commit intoapache:masterfrom
jrushford:plugin_verifier_bug_fix

Conversation

@jrushford
Copy link
Contributor

What does this PR (Pull Request) do?

This fixes a bug in the plugin_verifier so that it does notreport a malformed config when a plugin uses a long option
parameter in a @pparam field.

  • This PR fixes is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Ops ORT

What is the best way to verify this PR?

See the traffic_ops_ort/plugin_verifier/README.md and execute the
plugin_verifier against a copy of the remap.config which has entries
for the cachkey.so plugin using long options in its @pparam fields.
You should not see any errors.

If this is a bug fix, what versions of Traffic Control are affected?

  • master (b31db7)

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • [X This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

None

report a malformed config when a plugin uses a long option
parameter in a @pparam field.
Copy link
Member

@rob05c rob05c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Code looks good. ORT Integration Tests pass. I manually ran the plugin_verifier, it succeeds, false positives are gone.

@rob05c rob05c merged commit 7caafce into apache:master Apr 9, 2021
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our Go Format GHA reports some unformatted lines in traffic_ops_ort/plugin_verifier/plugin_verifier.go from #5716.

@rob05c
Copy link
Member

rob05c commented Apr 10, 2021

Odd, I thought all checks passed. But it looks like they didn't run at all? Well, I fixed #5734

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants