Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

renamed tr-tests GHA to tr-unit-tests#5912

Merged
zrhoffman merged 3 commits intoapache:masterfrom
bueale:master
Jun 7, 2021
Merged

renamed tr-tests GHA to tr-unit-tests#5912
zrhoffman merged 3 commits intoapache:masterfrom
bueale:master

Conversation

@bueale
Copy link
Copy Markdown
Contributor

@bueale bueale commented Jun 3, 2021

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Router
  • .github/actions/tr-unit-tests/action.yml
  • .github/actions/tr-unit-tests/README.md
  • .github/workflows/tr.unit.tests.yaml

What is the best way to verify this PR?

On the GitHub Actions run page: Run unit tests

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests
  • This PR does not require necessary documentation updates.
  • This PR includes NO necessary changes to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@bueale bueale changed the title renamed tr-tests to tr-unit-tests renamed tr-tests to tr-unit-tests to address https://github.com/apache/trafficcontrol/issues/5436 Jun 3, 2021
@mitchell852
Copy link
Copy Markdown
Member

@alebricio - make sure you complete the PR template

Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything changed so far looks fine. On the GitHub Actions run page:
test and Run unit tests
1.Can tests be reworded?
2. Can Run unit tests be reworded to specify which unit tests are being run?

@alebricio
Copy link
Copy Markdown
Contributor

@alebricio - make sure you complete the PR template

@mitchell852 I believe this was intended for @bueale

@mitchell852
Copy link
Copy Markdown
Member

mitchell852 commented Jun 3, 2021

@alebricio - make sure you complete the PR template

@mitchell852 I believe this was intended for @bueale

haha. sorry. @bueale ^^ also, no need to put the issue in the title. that's what the PR template is for. :)

@bueale bueale requested a review from zrhoffman June 4, 2021 16:26
@mitchell852 mitchell852 changed the title renamed tr-tests to tr-unit-tests to address https://github.com/apache/trafficcontrol/issues/5436 renamed tr-tests GHA to tr-unit-tests Jun 7, 2021
Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! On second thought, no need to rename the test job, because there is only 1 job, and all places where it is mentioned, you can see the name of the workflow anyway.

@zrhoffman zrhoffman merged commit 010420d into apache:master Jun 7, 2021
@mitchell852 mitchell852 added Traffic Router related to Traffic Router tests related to tests and/or testing infrastructure labels Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tests related to tests and/or testing infrastructure Traffic Router related to Traffic Router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename tr-tests github action to tr-unit-tests for clarity of scope

5 participants