This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix codeql t3c false positives#5923
Merged
mitchell852 merged 1 commit intoapache:masterfrom Jun 8, 2021
Merged
Conversation
Contributor
|
Alternatively, CodeQL scanning messages can just be dismissed as false positives by any committer |
Member
Author
|
I almost did that. But I figured it'd just pop up again with some other "vet" tool or person in a few months |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Fixes" codeql false positives.
None of these are actual issues. Checking for overflows is deceptive and not useful. For example, the Parent Rank being
2147483649is no more invalid than2147483645, but we don't have a hard limit on Parent Rank, so there's no sane max we can impose.But this is the path of least resistance. Much as it frustrates me to make code worse for bad tools, this will make tools stop bothering us every few months to fix things they don't have the context to understand aren't issues.
No new tests, code already has tests, and any specific tests around the overflow would be deceptive, misleading, and fallacious.
No docs, no interface change.
No changelog, no interface change, and these aren't real bugs.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run tests. Observe code is obviously identical in behavior, except for overflows astronomically larger than valid values.
If this is a bug fix, what versions of Traffic Control are affected?
Not a bug fix.
The following criteria are ALL met by this PR
Additional Information