This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Locking down snap/ queue/ update status endpoints for a CDN#5930
Merged
ocket8888 merged 6 commits intoapache:masterfrom Jun 23, 2021
Merged
Locking down snap/ queue/ update status endpoints for a CDN#5930ocket8888 merged 6 commits intoapache:masterfrom
ocket8888 merged 6 commits intoapache:masterfrom
Conversation
ocket8888
reviewed
Jun 11, 2021
ocket8888
reviewed
Jun 14, 2021
ocket8888
approved these changes
Jun 23, 2021
Contributor
ocket8888
left a comment
There was a problem hiding this comment.
Functionality works as described, the only failing tests are the ones that are failing currently on master due to known locale issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR adds the cdn locking capability to the snap/ queue/ update status endpoints.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure all the unit/ API tests pass.
Run TO and TP locally.
As user
A, send an API request to grab the lock for a particular CDNfoo.Now, try to snap
fooas userA-> this should succeedAfter this, log in to TO as another user
B, and try to snapfooas userB-> this should fail becauseAhas the lock forfooTry to snap any other CDN as user
BorA-> both operations should passRepeat the same tests for queueing and updating status of he servers on a CDN
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information