Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix failing CDNs integration tests in APIv4#5955

Merged
zrhoffman merged 1 commit intoapache:masterfrom
ocket8888:fix-integration-test
Jun 17, 2021
Merged

Fix failing CDNs integration tests in APIv4#5955
zrhoffman merged 1 commit intoapache:masterfrom
ocket8888:fix-integration-test

Conversation

@ocket8888
Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

This PR fixes the TO/Go client integration tests. There were two failures - one from checking the incorrect response code, and one that occurred because TO data was being altered by an earlier test that then never restored original state, and the test assumed a specific state of the data in TO. The fix I chose was to cause the first test to restore state before exiting.

Which Traffic Control components are affected by this PR?

  • Traffic Ops Client (Go) (tests only)

What is the best way to verify this PR?

Make sure the TO API/Go client integration tests pass.

If this is a bug fix, what versions of Traffic Control are affected?

  • master

The following criteria are ALL met by this PR

  • This PR includes tests
  • Documentation is unnecessary
  • An update to CHANGELOG.md is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one tests related to tests and/or testing infrastructure TO Client (Go) related to the Go implementation of a TC client labels Jun 17, 2021
Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestCDNs passes 👍
TestDeliveryServices fails, which is outside the scope of this PR.

@zrhoffman zrhoffman merged commit 251db03 into apache:master Jun 17, 2021
@ocket8888 ocket8888 deleted the fix-integration-test branch June 17, 2021 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one tests related to tests and/or testing infrastructure TO Client (Go) related to the Go implementation of a TC client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TO API test TestCDNs fails: Expected only one cdn response

2 participants