This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix Traffic Ops /deliveryserviceserver IMS requests#5965
Merged
zrhoffman merged 1 commit intoapache:masterfrom Jul 8, 2021
Merged
Fix Traffic Ops /deliveryserviceserver IMS requests#5965zrhoffman merged 1 commit intoapache:masterfrom
zrhoffman merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Not sure why an unrelated test is failing, but I probably won't have time this week, I'll try to investigate and fix next week |
Member
Author
|
Also, just to say: this is pretty important as far as IMS goes: Every t3c (nee ORT) run needs it, and it's a massive endpoint. |
zrhoffman
approved these changes
Jul 8, 2021
Member
zrhoffman
left a comment
There was a problem hiding this comment.
Fix looks good.
Verified that TestDeliveryServiceServers passes for API v3 and v4 and fails if Traffic Ops is rolled back 1 commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Traffic Ops
/deliveryserviceserverIf-Modified-Sincerequests.Includes tests.
Includes changelog.
No docs, no interface change.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run TO tests. Make an IMS request to
/deliveryserviceservernewer than the last change, verify a 304 is returned.If this is a bug fix, what versions of Traffic Control are affected?
5.0.x
The following criteria are ALL met by this PR
Additional Information