This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Handle pageination in Riak search#5980
Merged
mattjackson220 merged 6 commits intoapache:masterfrom Jul 8, 2021
shamrickus:to/riak-fix
Merged
Handle pageination in Riak search#5980mattjackson220 merged 6 commits intoapache:masterfrom shamrickus:to/riak-fix
mattjackson220 merged 6 commits intoapache:masterfrom
shamrickus:to/riak-fix
Conversation
mattjackson220
suggested changes
Jul 1, 2021
traffic_ops/traffic_ops_golang/trafficvault/backends/riaksvc/riak_services.go
Outdated
Show resolved
Hide resolved
mattjackson220
approved these changes
Jul 8, 2021
Contributor
mattjackson220
left a comment
There was a problem hiding this comment.
Looks good to me! code looks good, tested locally in CiaB and works as expected.
Contributor
|
TO Go client/API integration tests will pass if you rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
I have written the tests for this change, but given that it takes ~8 minutes I've decided to omit it.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Create >1000 DS with sslkeys on a single cdn, call
cdns/name/{name}/sslkeysand verify it returns more than 1000 records.Create >1000 SSLKeys on a single CDN (doesn't matter if it's one or many DS'). Then make a change (such as moving a DS to another CDN) that modifies more than 1000 ssl certs the cdn. Finally, perform a snapshot. Only 1000 of the SSLKey records will have been removed/updated.
The order in which these are returned is transient as far as I can tell, so which 1000 are changed differs each run.
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information