Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Handle pageination in Riak search#5980

Merged
mattjackson220 merged 6 commits intoapache:masterfrom
shamrickus:to/riak-fix
Jul 8, 2021
Merged

Handle pageination in Riak search#5980
mattjackson220 merged 6 commits intoapache:masterfrom
shamrickus:to/riak-fix

Conversation

@shamrickus
Copy link
Member

@shamrickus shamrickus commented Jun 28, 2021

What does this PR (Pull Request) do?

I have written the tests for this change, but given that it takes ~8 minutes I've decided to omit it.

Which Traffic Control components are affected by this PR?

  • Traffic Ops
  • Traffic Vault

What is the best way to verify this PR?

Create >1000 DS with sslkeys on a single cdn, call cdns/name/{name}/sslkeys and verify it returns more than 1000 records.
Create >1000 SSLKeys on a single CDN (doesn't matter if it's one or many DS'). Then make a change (such as moving a DS to another CDN) that modifies more than 1000 ssl certs the cdn. Finally, perform a snapshot. Only 1000 of the SSLKey records will have been removed/updated.
The order in which these are returned is transient as far as I can tell, so which 1000 are changed differs each run.

If this is a bug fix, what versions of Traffic Control are affected?

  • every version

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@rawlinp rawlinp added improvement The functionality exists but it could be improved in some way. Traffic Ops related to Traffic Ops Traffic Vault related to Traffic Vault bug something isn't working as intended and removed improvement The functionality exists but it could be improved in some way. labels Jun 28, 2021
Copy link
Contributor

@mattjackson220 mattjackson220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! code looks good, tested locally in CiaB and works as expected.

@ocket8888
Copy link
Contributor

TO Go client/API integration tests will pass if you rebase

@mattjackson220 mattjackson220 merged commit 1cfa82b into apache:master Jul 8, 2021
@shamrickus shamrickus deleted the to/riak-fix branch July 8, 2021 22:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Ops related to Traffic Ops Traffic Vault related to Traffic Vault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TO riak client is unable to get more than 1000 records

4 participants