This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Add t3c If-Modified-Since Support#5985
Merged
rawlinp merged 2 commits intoapache:masterfrom Jul 13, 2021
Merged
Conversation
rob05c
added
new feature
rob05c
force-pushed
the
add-t3c-ims
branch
5 times, most recently
from
64a09c1 to
2c4f2f4
Compare
rawlinp
reviewed
Jun 30, 2021
Contributor
There was a problem hiding this comment.
Should these be called ResponseHeaders as opposed to just Headers? I think these could be confused as request headers, since the type name is short for "request info".
rob05c
force-pushed
the
add-t3c-ims
branch
2 times, most recently
from
0519475 to
cc1fc56
Compare
As requested in PR Review.
alficles
approved these changes
Jul 13, 2021
Contributor
alficles
left a comment
alficles
left a comment
There was a problem hiding this comment.
Sorry for the delay. This is good to go, I think. Caching these requests will help considerably and this handles the caching correctly.
Contributor
There was a problem hiding this comment.
Tiny nit: There's no reason for a memory allocation here. This could be nil instead. But performance here is of no concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds t3c using If-Modified-Since requests to avoid making unnecessary requests to Traffic Ops.
Includes a feature flag
t3c-apply --no-cacheto disable.Includes tests.
Includes docs.
Includes changelog.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run tests. Run t3c twice, verify requests are not made for most endpoints (Traffic Ops doesn't support IMS on Riak "Vault" endpoints, and some are currently broken, but most should work).
If this is a bug fix, what versions of Traffic Control are affected?
Not a bug fix.
The following criteria are ALL met by this PR
Additional Information