This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Merged
Conversation
rob05c
added
new feature
rob05c
force-pushed
the
add-t3c-mode-flags
branch
from
ea81993 to
e680b98
Compare
ezelkow1
approved these changes
Jul 8, 2021
Member
ezelkow1
left a comment
ezelkow1
left a comment
There was a problem hiding this comment.
tested locally and what i tested still seemed functional and working
rob05c
force-pushed
the
add-t3c-mode-flags
branch
2 times, most recently
from
cf14923 to
27a6c48
Compare
rob05c
force-pushed
the
add-t3c-mode-flags
branch
2 times, most recently
from
2fe6d93 to
ea2bc27
Compare
rob05c
force-pushed
the
add-t3c-mode-flags
branch
3 times, most recently
from
a4e89af to
897963f
Compare
rob05c
force-pushed
the
add-t3c-mode-flags
branch
from
897963f to
e7406d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds flags for all the actual behaviors of t3c-apply (nee ORT) modes:
--report-only --files --install-packages --service-action --ignore-update-flag --update-ipallow --no-unset-update-flag --wait-for-parents --report-only,Changes the internal code for mode flags to set the real behavior flags,
Changes all config struct to not store the mode, and all behavioral logic to operate on the actual behavior flag.
The intent is to make the app more flexible and powerful, and to make it easier to work with and more obvious and less subtle and confusing exactly what each mode does.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run tests. Run t3c-apply with modes and new behavior flags, verify behavior is expected.
If this is a bug fix, what versions of Traffic Control are affected?
Not a bug.
The following criteria are ALL met by this PR
Additional Information